Skip to content

refactor(config): deprecate packageJson option#2034

Merged
ahnpnl merged 1 commit intokulshekhar:masterfrom
ahnpnl:refactor-config-3
Oct 18, 2020
Merged

refactor(config): deprecate packageJson option#2034
ahnpnl merged 1 commit intokulshekhar:masterfrom
ahnpnl:refactor-config-3

Conversation

@ahnpnl
Copy link
Copy Markdown
Collaborator

@ahnpnl ahnpnl commented Oct 17, 2020

Summary

This option is not used internally so we can deprecate it and remove it in v27

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner October 17, 2020 16:15
@coveralls
Copy link
Copy Markdown

coveralls commented Oct 17, 2020

Pull Request Test Coverage Report for Build 6162

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 93.533%

Totals Coverage Status
Change from base Build 6160: -0.003%
Covered Lines: 1083
Relevant Lines: 1114

💛 - Coveralls

Comment thread src/config/config-set.spec.ts Outdated
Comment thread src/config/config-set.spec.ts Outdated
The option `packageJson` is not used in internal `ts-jest` so it makes sense to remove it.
@ahnpnl ahnpnl merged commit 1538fa6 into kulshekhar:master Oct 18, 2020
@ahnpnl ahnpnl deleted the refactor-config-3 branch October 18, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants